leventov commented on a change in pull request #7185: Avoid many unnecessary
materializations of collections of 'all segments in cluster' cardinality
URL: https://github.com/apache/incubator-druid/pull/7185#discussion_r264306493
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/rules/Rule.java
##########
@@ -52,5 +51,14 @@
boolean appliesTo(Interval interval, DateTime referenceTimestamp);
+ /**
+ * {@link DruidCoordinatorRuntimeParams#getAvailableSegments()} must not be
called in Rule's code, because the
+ * available segments are not specified for the {@link
DruidCoordinatorRuntimeParams} passed into Rule's code. This is
+ * because {@link DruidCoordinatorRuntimeParams} entangles two slightly
different (nonexistent yet) abstractions:
+ * "DruidCoordinatorHelperParams" and "RuleParams" which contain params that
only {@link
Review comment:
Anyway, created #7228 to track that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
