leventov commented on a change in pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality URL: https://github.com/apache/incubator-druid/pull/7185#discussion_r264327958
########## File path: server/src/main/java/org/apache/druid/metadata/MetadataSegmentManager.java ########## @@ -59,6 +60,8 @@ Collection<ImmutableDruidDataSource> getDataSources(); + Iterable<DataSegment> iterateAllSegments(); Review comment: Appears that I (without realizing) used the same prefix as in `SegmentId.iterateAllPossibleParsings()` (which is also a "lazy and not cheap iteration"). Looks like an emerging naming pattern. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
