glasser commented on a change in pull request #7048: Make
IngestSegmentFirehoseFactory splittable for parallel ingestion
URL: https://github.com/apache/incubator-druid/pull/7048#discussion_r264387445
##########
File path:
indexing-service/src/test/java/org/apache/druid/indexing/firehose/IngestSegmentFirehoseFactoryTimelineTest.java
##########
@@ -146,6 +161,36 @@ public void testSimple() throws Exception
Assert.assertEquals("sum", expectedSum, sum);
}
+ private void testSplit() throws Exception
+ {
+ Assert.assertTrue(factory.isSplittable());
+ final int numSplits = factory.getNumSplits();
+ // We set maxInputSegmentBytesPerSplit to 2 so each segment should become
a byte.
+ Assert.assertEquals(segmentCount, numSplits);
+ final List<InputSplit<List<WindowedSegmentId>>> splits =
+ factory.getSplits().collect(Collectors.toList());
+ Assert.assertEquals(numSplits, splits.size());
+
+ int count = 0;
+ long sum = 0;
+
+ for (InputSplit<List<WindowedSegmentId>> split : splits) {
+ final FiniteFirehoseFactory<InputRowParser, List<WindowedSegmentId>>
splitFactory =
+ factory.withSplit(split);
+ try (final Firehose firehose = splitFactory.connect(ROW_PARSER, null)) {
+ while (firehose.hasMore()) {
+ final InputRow row = firehose.nextRow();
+ count++;
+ sum += row.getMetric(METRICS[0]).longValue();
Review comment:
TeamCity complains that both method calls here may cause NPEs. It is just a
duplicate of existing code with the same problem in testSimple, though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
