gianm opened a new pull request, #19417:
URL: https://github.com/apache/druid/pull/19417
PR #18745 included a discussion of desired behavior of taskCount,
taskCountStart, and taskCountMin, but this has not been fully implemented.
There are two missed cases:
1) On OL / supervisor restart, the persisted taskCount should be used.
Currently, the persisted taskCountStart is used instead if set.
2) On supervisor POST, the previous spec's taskCount should be used if
the user provides neither taskCount nor taskCountStart. Currently,
in this case, the user's provided taskCountMin is used instead.
In addition, and related to (1), currently deserialization of the ioConfig
causes the taskCount to be overwritten by the taskCountStart. This causes the
get supervisor and supervisor history APIs to return inaccurate taskCounts.
This patch fixes these issues by doing two things:
1) Update SeekableStreamSupervisorIOConfig to always retain taskCount
from the constructor (i.e. when deserializing) if set.
2) Update SeekableStreamSupervisorSpec#merge to handle the special
case that taskCountStart has priority on POST.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
