rmn7 opened a new pull request, #19419:
URL: https://github.com/apache/druid/pull/19419
### Description
To use different pod templates for different tasks, users today have to
setup an `executionconfig` with a `selectorBased` strategy, setup equivalent
tags on this config and pass these tags to the task context. This change allows
the `DynamicConfigPodTemplateSelector` to use a new `podTemplateSelectionKey`
context key from the task to directly pick the pod template based on its
`selectionKey` in the runtime properties. I chose to fail task creation instead
of falling back to the existing selection strategy since users would only set
this context param intentionally and a missing pod template indicates
misconfiguration.
#### Release note
You can now set podTemplateSelectionKey in a task's context to pick a
specific configured pod template (e.g.
`druid.indexer.runner.k8s.podTemplate.<selectionKey>`) without configuring a
selectorBased strategy. The override takes precedence over both the default and
selectorBased strategies. If the named template isn't configured, the task
fails to launch.
<hr>
##### Key changed/added classes in this PR
* `DynamicConfigPodTemplateSelector`
<hr>
This PR has:
- [x] been self-reviewed.
- [x] added documentation for new or modified features or behaviors.
- [x] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
