Shekharrajak commented on code in PR #19311:
URL: https://github.com/apache/druid/pull/19311#discussion_r3212557778
##########
extensions-core/kafka-indexing-service/pom.xml:
##########
@@ -252,6 +257,30 @@
</execution>
</executions>
</plugin>
+ <plugin>
+ <!--
+ The bundled in-JVM test broker (kafka_2.13:3.9.x, ZooKeeper-mode) was
+ compiled against kafka-clients 3.9.x and references
Utils.mkSet(Object[]),
+ which was removed in kafka-clients 4.x. This module pins
kafka-clients to
+ 4.2.0 to enable KIP-932 share-group support, so KafkaConfig static
+ initialization throws NoSuchMethodError under any JVM. The tests
below
+ depend on TestBroker and must be skipped until the test broker
migrates to
+ kafka_2.13:4.x (KRaft) or Testcontainers. Share-group code paths are
+ covered by ShareGroupIndexTaskRunnerTest,
KafkaShareGroupRecordSupplierTest
+ (mock-based) and embedded-tests/EmbeddedShareGroupIngestionTest
+ (Testcontainers). Tracked as a follow-up of apache/druid#19311.
+ -->
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <excludes>
+ <exclude>**/KafkaIndexTaskTest.java</exclude>
Review Comment:
Yes, planning to fix (upgrade to 4.2 version in all places) as part of this
https://github.com/apache/druid/issues/19322 - I feel that we need bunch of
changes, API compatibility issues in running tests , kafka docker image for IT
tests and in source code - so want to keep it in separate PR.
This PR mainly focus on Share group implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
