aho135 commented on code in PR #19386:
URL: https://github.com/apache/druid/pull/19386#discussion_r3230018939
##########
processing/src/main/java/org/apache/druid/segment/virtual/ExpressionVirtualColumn.java:
##########
@@ -427,16 +427,15 @@ private boolean isDirectAccess(final ColumnInspector
inspector)
private Supplier<byte[]> makeCacheKeySupplier()
{
- return Suppliers.memoize(() -> {
+ return () -> {
Review Comment:
Should memoize be conditional depending on whether the expression
isNonDeterministic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
