abhishekrb19 commented on code in PR #19386:
URL: https://github.com/apache/druid/pull/19386#discussion_r3230264584
##########
processing/src/main/java/org/apache/druid/segment/transform/ExpressionTransform.java:
##########
@@ -57,6 +60,13 @@ public ExpressionTransform(
this.parsedExpression = Suppliers.memoize(
() -> Parser.parse(expression,
Preconditions.checkNotNull(this.macroTable, "macroTable"))
)::get;
+
+ if (ColumnHolder.TIME_COLUMN_NAME.equals(name)
+ && BuiltInExprMacros.NowExprMacro.containsNow(parsedExpression.get()))
{
Review Comment:
Yeah, good point, updated. I think we can make this be the case for all
non-deterministic expressions (`now()` being the only one currently)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
