GWphua commented on code in PR #19459:
URL: https://github.com/apache/druid/pull/19459#discussion_r3232801964
##########
docs/querying/sql-metadata-tables.md:
##########
@@ -322,7 +322,7 @@ SELECT * FROM sys.supervisors WHERE healthy=0;
### SERVER_PROPERTIES table
-The `server_properties` table exposes the runtime properties configured on for
each Druid server. Each row represents a single property key-value pair
associated with a specific server.
+The `server_properties` table exposes the runtime properties configured on
each Druid server. Each row represents a single property key-value pair
associated with a specific server. This table supports filter and projection
pushdown for efficient querying. If a server is unreachable, the table still
returns a row for that server with the `error` column populated instead of
failing the entire query.
Review Comment:
```suggestion
The `server_properties` table exposes the runtime properties configured on
each Druid server. Each row represents a single property key-value pair
associated with a specific server. This table supports filter and projection
pushdown for efficient querying. If a server is unreachable, the table still
returns a row for that server with the `error_message` column populated instead
of failing the entire query.
```
##########
embedded-tests/src/test/java/org/apache/druid/testing/embedded/schema/SystemServerPropertiesTableTest.java:
##########
@@ -146,6 +146,13 @@ public void test_serverPropertiesTable_hiddenProperties()
Assertions.assertFalse(brokerProps.containsKey("password"));
}
+ @Test
+ public void test_serverPropertiesTable_errorMessageColumnExists()
+ {
+ final String result = cluster.runSql("SELECT COUNT(*) FROM
sys.server_properties WHERE error_message IS NULL");
+ Assertions.assertFalse(result.isEmpty(), "Should return count of servers
with null error_message");
Review Comment:
nit: I think this test just checks if the query did not fail. Can we make
the test stronger? For example, asserting a return of a known value (e.g.
0,1,etc.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
