abhishekrb19 commented on code in PR #19459:
URL: https://github.com/apache/druid/pull/19459#discussion_r3235373822


##########
sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemServerPropertiesTable.java:
##########
@@ -108,42 +121,62 @@ public Schema.TableType getJdbcTableType()
   }
 
   @Override
-  public Enumerable<Object[]> scan(DataContext root)
+  public Enumerable<Object[]> scan(
+      final DataContext root,
+      final List<RexNode> filters,

Review Comment:
   Yeah, the initial version had some filter pushdown that was slightly 
complex. Currently, it supports equality filters on the `server` and 
`service_name` columns. It falls back to querying all servers if it detects any 
other filter predicate or column.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to