clintropolis commented on code in PR #19461:
URL: https://github.com/apache/druid/pull/19461#discussion_r3239280039


##########
server/src/main/java/org/apache/druid/server/coordinator/ServerHolder.java:
##########
@@ -387,6 +400,16 @@ public int getNumQueuedSegments()
   }
 
   public boolean startOperation(SegmentAction action, DataSegment segment)
+  {
+    return startOperation(action, segment, null);
+  }
+
+  /**
+   * Like {@link #startOperation(SegmentAction, DataSegment)}, but 
additionally records the {@link PartialLoadProfile}

Review Comment:
   oops, refactored some things while iterating on this stuff to consolidate 
and forgot to update 😅 
   
   I did another pass on the javadoc and think this (and a bunch of other 
places) should be better now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to