clintropolis commented on code in PR #19461:
URL: https://github.com/apache/druid/pull/19461#discussion_r3242997200
##########
server/src/main/java/org/apache/druid/server/http/SegmentLoadingCapabilities.java:
##########
@@ -30,27 +30,15 @@ public class SegmentLoadingCapabilities
{
private final int numLoadingThreads;
private final int numTurboLoadingThreads;
- private final boolean supportsPartialLoad;
@JsonCreator
public SegmentLoadingCapabilities(
Review Comment:
To elaborate a bit more on why i removed `supportsPartialLoad `, with it
existing and the coordinator considering it for assignment, when actually in
this scenario it creates hot spots whenever you roll between versions; like if
only a single server in a tier supports partial loads then all partial loads
are assigned to the single server. This seemed like more problems than benefits.
With regards to older versions of historicals not understanding the new
partial load specs, without the flag existing I plan to just document this as
new functionality that should not be used until an operator is certain that
there is no need to roll back, the same we do with certain types of other new
features (like segment format stuff).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
