FrankChen021 commented on code in PR #19462:
URL: https://github.com/apache/druid/pull/19462#discussion_r3241077274
##########
processing/src/main/java/org/apache/druid/timeline/DataSegment.java:
##########
@@ -247,6 +273,7 @@ public DataSegment(
@Nullable List<String> dimensions,
@Nullable List<String> metrics,
@Nullable List<String> projections,
+ @Nullable ClusterGroupTuples clusterGroups,
Review Comment:
[P2] Keep the existing public constructor signature
This inserts clusterGroups into the public constructor that previously took
(... projections, ShardSpec, CompactionState, ...). DataSegment is annotated
@PublicApi, and extension or application code can construct projection-aware
segments with that old signature; after this change those callers either fail
to compile or, if already compiled, hit NoSuchMethodError even though they do
not use cluster groups. Please keep the old overload and delegate with
clusterGroups = null instead of replacing the existing public signature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
