clintropolis commented on code in PR #19462:
URL: https://github.com/apache/druid/pull/19462#discussion_r3243762318
##########
processing/src/main/java/org/apache/druid/timeline/DataSegment.java:
##########
@@ -247,6 +273,7 @@ public DataSegment(
@Nullable List<String> dimensions,
@Nullable List<String> metrics,
@Nullable List<String> projections,
+ @Nullable ClusterGroupTuples clusterGroups,
Review Comment:
fine, I can add it... `DataSegment` is a bit of a graveyard of deprecated
constructors and builder creators though... we need to delete these at some
point and just call it out in release notes. I would expect creating
`DataSegment` directly is kind of uncommon in extensions (outside of tests at
least).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
