github-advanced-security[bot] commented on code in PR #19467:
URL: https://github.com/apache/druid/pull/19467#discussion_r3254111132
##########
indexing-service/src/test/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunnerTest.java:
##########
@@ -437,7 +724,17 @@
@Override
protected OrderedSequenceNumber createSequenceNumber(Object sequenceNumber)
{
- return null;
+ if (sequenceNumber == null) {
+ return null;
+ }
+ return new OrderedSequenceNumber<>(sequenceNumber.toString(), false)
+ {
Review Comment:
## CodeQL / Inconsistent compareTo
This class declares [compareTo](1) but inherits equals; the two could be
inconsistent.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11236)
##########
indexing-service/src/test/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunnerTest.java:
##########
@@ -437,7 +724,17 @@
@Override
protected OrderedSequenceNumber createSequenceNumber(Object sequenceNumber)
{
- return null;
+ if (sequenceNumber == null) {
+ return null;
+ }
+ return new OrderedSequenceNumber<>(sequenceNumber.toString(), false)
+ {
+ @Override
+ public int compareTo(OrderedSequenceNumber<String> other)
+ {
+ return Long.compare(Long.parseLong(get()),
Long.parseLong(other.get()));
+ }
Review Comment:
## CodeQL / Missing catch of NumberFormatException
Potential uncaught 'java.lang.NumberFormatException'.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11235)
##########
indexing-service/src/test/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunnerTest.java:
##########
@@ -437,7 +724,17 @@
@Override
protected OrderedSequenceNumber createSequenceNumber(Object sequenceNumber)
{
- return null;
+ if (sequenceNumber == null) {
+ return null;
+ }
+ return new OrderedSequenceNumber<>(sequenceNumber.toString(), false)
+ {
+ @Override
+ public int compareTo(OrderedSequenceNumber<String> other)
+ {
+ return Long.compare(Long.parseLong(get()),
Long.parseLong(other.get()));
+ }
Review Comment:
## CodeQL / Missing catch of NumberFormatException
Potential uncaught 'java.lang.NumberFormatException'.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11234)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
