gianm commented on code in PR #19467:
URL: https://github.com/apache/druid/pull/19467#discussion_r3262578388
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java:
##########
@@ -243,7 +243,8 @@ public enum Status
protected volatile boolean pauseRequested = false;
private volatile long nextCheckpointTime;
- private volatile CopyOnWriteArrayList<SequenceMetadata<PartitionIdType,
SequenceOffsetType>> sequences;
+ private final Lock sequencesLock = new ReentrantLock();
+ private List<SequenceMetadata<PartitionIdType, SequenceOffsetType>>
sequences = new ArrayList<>();
Review Comment:
Can we use `@GuardedBy("sequencesLock")` here to enforce proper locking?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
