FrankChen021 commented on code in PR #19477: URL: https://github.com/apache/druid/pull/19477#discussion_r3273987318
########## extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/supervisor/KinesisSupervisor.java: ########## @@ -336,7 +336,7 @@ protected OrderedSequenceNumber<String> makeSequenceNumber(String seq, boolean i } @Override - protected void updatePartitionLagFromStream() + public void updatePartitionLagFromStream() Review Comment: Thanks for confirming. I reviewed all 11 changed files in the current head; since this PR still exposes `/resetOffsetsAndBackfill` to every `SeekableStreamSupervisor`, Kinesis still reaches `SupervisorManager.resetSupervisorAndBackfill()`, calls `updatePartitionLagFromStream()`, then sees the base empty `getLatestSequencesFromStream()` and returns a 500. If Kinesis support is intentionally deferred, can this PR explicitly reject or disable Kinesis and document the supported supervisor types, rather than leaving the new endpoint available but broken until the follow-up PR lands? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
