aho135 commented on code in PR #19477: URL: https://github.com/apache/druid/pull/19477#discussion_r3277494947
########## extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/supervisor/KinesisSupervisor.java: ########## @@ -336,7 +336,7 @@ protected OrderedSequenceNumber<String> makeSequenceNumber(String seq, boolean i } @Override - protected void updatePartitionLagFromStream() + public void updatePartitionLagFromStream() Review Comment: Thanks for the review @FrankChen021! I'm not able to do an `instanceof` check in SupervisorManager due to module dependencies. I could add something like `supportsResetAndBackfill` to `SeekableStreamSupervisor` but seems like overkill given that it'll be reverted after `getLatestSequencesFromStream()` is implemented for Kinesis. Given that the current response of 500 is accurate I think it's fine for now Alternatively we can hold off on merging this until the Kinesis changes are in -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
