github-advanced-security[bot] commented on code in PR #19541:
URL: https://github.com/apache/druid/pull/19541#discussion_r3337745834


##########
indexing-service/src/test/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorSpecTest.java:
##########
@@ -829,28 +810,18 @@
   @Test
   public void testSeekableStreamSupervisorSpecWithScaleDisable() throws 
InterruptedException
   {
-    SeekableStreamSupervisorIOConfig seekableStreamSupervisorIOConfig = new 
SeekableStreamSupervisorIOConfig(
-        "stream",
-        new JsonInputFormat(new JSONPathSpec(true, ImmutableList.of()), 
ImmutableMap.of(), false, false, false),
-        1,
-        1,
-        new Period("PT1H"),
-        new Period("P1D"),
-        new Period("PT30S"),
-        false,
-        new Period("PT30M"),
-        null,
-        null,
-        null,
-        LagAggregator.DEFAULT,
-        null,
-        null,
-        null,
-        null,
-        null
-    )
-    {
-    };
+    SeekableStreamSupervisorIOConfig seekableStreamSupervisorIOConfig = new 
SupervisorIOConfigBuilder.DefaultSupervisorIOConfigBuilder()
+        .withStream("stream")
+        .withInputFormat(new JsonInputFormat(new JSONPathSpec(true, 
ImmutableList.of()), ImmutableMap.of(), false, false, false))
+        .withReplicas(1)
+        .withTaskCount(1)
+        .withTaskDuration(new Period("PT1H"))
+        .withStartDelay(new Period("P1D"))
+        .withSupervisorRunPeriod(new Period("PT30S"))
+        .withUseEarliestSequenceNumber(false)
+        .withCompletionTimeout(new Period("PT30M"))
+        .withLagAggregator(LagAggregator.DEFAULT)
+        .build();

Review Comment:
   ## CodeQL / Possible confusion of local and field
   
   Potentially confusing name: method 
[testSeekableStreamSupervisorSpecWithScaleDisable](1) also refers to field 
[seekableStreamSupervisorIOConfig](2) (as 
this.seekableStreamSupervisorIOConfig).
   
   [Show more 
details](https://github.com/apache/druid/security/code-scanning/11285)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to