Shekharrajak commented on code in PR #19510: URL: https://github.com/apache/druid/pull/19510#discussion_r3343264779
########## extensions-contrib/druid-iceberg-extensions/src/main/java/org/apache/druid/iceberg/input/IcebergInputSource.java: ########## Review Comment: This make sense, Updated: https://github.com/apache/druid/pull/19510/changes/bf71afb428ec50c1518cd5d68e4743fdc7714468 AbstractIcebergInputSource — shared metadata fields . IcebergArrowInputSource extends AbstractIcebergInputSource implements InputSource — type "iceberg_arrow", non-splittable, needsFormat() = false, owns arrowBatchSize. Calls IcebergArrowInputSourceReader directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
