FrankChen021 commented on code in PR #19545:
URL: https://github.com/apache/druid/pull/19545#discussion_r3348713625
##########
processing/src/main/java/org/apache/druid/query/QueryContexts.java:
##########
@@ -256,7 +256,9 @@ public enum RealtimeSegmentsMode
/** Query only realtime segments. */
EXCLUSIVE,
/** Skip realtime segments; query only historical. */
- EXCLUDE;
+ EXCLUDE,
+ /** Skip partial in memory realtime segments that have not yet been
indexed */
+ EXCLUDE_INCREMENTAL;
Review Comment:
[P2] Update realtime mode tests for the new enum value
Adding EXCLUDE_INCREMENTAL changes the enum constants used by
QueryContexts.getAsEnum when it builds invalid-value error messages.
QueryContextTest#testGetRealtimeSegmentsModeInvalidValue still asserts the old
list [INCLUDE,EXCLUSIVE,EXCLUDE], so it will now fail once the message includes
EXCLUDE_INCREMENTAL. Please update that expectation and add direct coverage
that realtimeSegmentsMode=exclude_incremental parses to EXCLUDE_INCREMENTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
