jtuglu1 commented on PR #19501: URL: https://github.com/apache/druid/pull/19501#issuecomment-4624024611
> Severity Findings > P0 0 > P1 1 > P2 0 > P3 0 > Total 1 > Reviewed 23 of 23 changed files. > > Findings that could not be attached inline: > > * indexing-service/src/main/java/org/apache/druid/indexing/overlord/http/OverlordCompactionResource.java:284 - [P1] Honor If-Match on unified datasource compaction writes. When compaction supervisors are disabled, the unified datasource POST and DELETE fallback paths still mutate the same DruidCompactionConfig document through overloads that do not receive DynamicConfigEtagHelper.getIfMatch(...). A client can read the compaction ETag, race with another config write, then POST or DELETE /druid/indexer/v1/compaction/config/datasources/... with a stale If-Match header and still get a successful write instead of 412. Thread the If-Match value through both fallback calls, or explicitly reject conditional requests there. This appears unchanged from the prior review. > > This is an automated review by Codex GPT-5.5 @cecemei @FrankChen021 how do you folks want to handle these internal updates? ETag with retries seems like the best option, although I'm not sure allowing possibility for mutations to be completely blocked is acceptable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
