FrankChen021 commented on code in PR #19591: URL: https://github.com/apache/druid/pull/19591#discussion_r3427977326
########## docs/configuration/index.md: ########## @@ -1645,6 +1645,8 @@ These Broker configurations can be defined in the `broker/runtime.properties` fi |`druid.broker.select.tier.custom.priorities`|An array of integer priorities, such as `[-1, 0, 1, 2]`|Select servers in tiers with a custom priority list.|The config only has effect if `druid.broker.select.tier` is set to `custom`. If `druid.broker.select.tier` is set to `custom` but this config is not specified, the effect is the same as `druid.broker.select.tier` set to `highestPriority`. Any of the integers in this config can be ignored if there's no corresponding tiers with such priorities. Tiers with priorities explicitly specified in this config always have higher priority than those not and those not specified fall back to use `highestPriority` strategy among themselves.| |`druid.broker.select.tier.preferred.tier`| The preferred tier name. E.g., `_default_tier` | A non-empty value that specifies the preferred tier in which historical servers will be picked up for queries. If there are not enough historical servers from the preferred tier, servers from other tiers (if there are any) will be selected. This config only has effect if `druid.broker.select.tier` is set to `preferred` | null | |`druid.broker.select.tier.preferred.priority`| `highest`, `lowest` | If there are multiple candidates in a preferred tier, specifies the priority to pick up candidates. By default, the higher priority a historical, the higher chances it will be picked up. This config only has effect if `druid.broker.select.tier` is set to `preferred`| `highest` | +|`druid.broker.realtime.balancer.type`|`random`, `connectionCount`|Determines how the broker balances connections to realtime processes. This overrides `druid.broker.balancer.type` for realtime servers only; Historical processes are unaffected. If not set, realtime servers use the strategy configured by `druid.broker.balancer.type`.|Value of `druid.broker.balancer.type`| Review Comment: [P2] Realtime balancer override is documented as standalone This row says `druid.broker.realtime.balancer.type` overrides the historical balancer for realtime servers, but `RealtimeTierSelectorStrategyProvider` only constructs a realtime tier selector with the realtime `ServerSelectorStrategy` when `druid.broker.realtime.select.tier` is set. If only the balancer override is configured, it returns the default historical `TierSelectorStrategy`, so realtime server picking still uses the default balancer. Either fix that implementation path or document the dependency so operators do not configure a no-op override. ########## docs/configuration/index.md: ########## @@ -1645,6 +1645,8 @@ These Broker configurations can be defined in the `broker/runtime.properties` fi |`druid.broker.select.tier.custom.priorities`|An array of integer priorities, such as `[-1, 0, 1, 2]`|Select servers in tiers with a custom priority list.|The config only has effect if `druid.broker.select.tier` is set to `custom`. If `druid.broker.select.tier` is set to `custom` but this config is not specified, the effect is the same as `druid.broker.select.tier` set to `highestPriority`. Any of the integers in this config can be ignored if there's no corresponding tiers with such priorities. Tiers with priorities explicitly specified in this config always have higher priority than those not and those not specified fall back to use `highestPriority` strategy among themselves.| |`druid.broker.select.tier.preferred.tier`| The preferred tier name. E.g., `_default_tier` | A non-empty value that specifies the preferred tier in which historical servers will be picked up for queries. If there are not enough historical servers from the preferred tier, servers from other tiers (if there are any) will be selected. This config only has effect if `druid.broker.select.tier` is set to `preferred` | null | |`druid.broker.select.tier.preferred.priority`| `highest`, `lowest` | If there are multiple candidates in a preferred tier, specifies the priority to pick up candidates. By default, the higher priority a historical, the higher chances it will be picked up. This config only has effect if `druid.broker.select.tier` is set to `preferred`| `highest` | +|`druid.broker.realtime.balancer.type`|`random`, `connectionCount`|Determines how the broker balances connections to realtime processes. This overrides `druid.broker.balancer.type` for realtime servers only; Historical processes are unaffected. If not set, realtime servers use the strategy configured by `druid.broker.balancer.type`.|Value of `druid.broker.balancer.type`| +|`druid.broker.realtime.select.tier`|`highestPriority`, `lowestPriority`, `custom`, `preferred`|Tier selection strategy for realtime processes. This overrides `druid.broker.select.tier` for realtime servers only; Historical processes are unaffected. If not set, realtime servers use the strategy configured by `druid.broker.select.tier`. The corresponding sub-configs `druid.broker.realtime.select.tier.custom.priorities`, `druid.broker.realtime.select.tier.preferred.tier`, and `druid.broker.realtime.select.tier.preferred.priority` behave the same as their `druid.broker.select.tier.*` counterparts.|Value of `druid.broker.select.tier`| Review Comment: [P3] Supported realtime tier strategies are omitted `BrokerRealtimeSelectorModule` and `TierSelectorStrategy` also support `strict` and `pooled` for `druid.broker.realtime.select.tier`, and the tests exercise `druid.broker.realtime.select.tier.strict.priorities` and `druid.broker.realtime.select.tier.pooled.priorities`. The new docs row lists only `highestPriority`, `lowestPriority`, `custom`, and `preferred`, and only mentions the custom/preferred sub-configs, so valid realtime selector configurations remain undocumented. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
