FrankChen021 commented on code in PR #19637: URL: https://github.com/apache/druid/pull/19637#discussion_r3536285684
########## docs/tutorials/tutorial-batch.md: ########## @@ -118,14 +118,19 @@ Once the spec is submitted, wait a few moments for the data to load, after which ## Loading data with a spec (via command line) -For convenience, the Druid package includes a batch ingestion helper script at `bin/post-index-task`. - -This script will POST an ingestion task to the Druid Overlord and poll Druid until the data is available for querying. +To load data with a spec, you need to POST an ingestion task to the Druid Overlord and poll Druid until the data is available for querying. Run the following command from Druid package root: ```bash -bin/post-index-task --file quickstart/tutorial/wikipedia-index.json --url http://localhost:8081 +curl -X POST http://localhost:8081/druid/indexer/v1/task \ Review Comment: [P2] Curl example still promises script polling output After replacing `bin/post-index-task` with plain `curl`, this section still says the command polls until data is queryable and shows the old helper output with task-status/log lines and loading-complete text. `curl` only submits the task and returns the task id, so readers will not see the documented output or get a working polling step. Remove or update the stale output and add explicit status-polling or console wait guidance. ########## docs/tutorials/tutorial-ingestion-spec.md: ########## @@ -580,13 +580,15 @@ We've finished defining the ingestion spec, it should now look like the followin ## Submit the task and query the data -From the `apache-druid-{{DRUIDVERSION}}` package root, run the following command: +From the `apache-druid-{{DRUIDVERSION}}` package root, run the following command to create a datasource called `ingestion tutorial`: ```bash -bin/post-index-task --file quickstart/ingestion-tutorial-index.json --url http://localhost:8081 +curl -X POST http://localhost:8081/druid/indexer/v1/task \ + -H "Content-Type: application/json" \ + -d @quickstart/tutorial/ingestion-tutorial-index.json Review Comment: [P2] Submit command uses the wrong spec path Earlier in this tutorial, readers create `ingestion-tutorial-index.json` in `quickstart/`, and the previous helper command submitted `quickstart/ingestion-tutorial-index.json`. This PR changed the `curl` payload to `@quickstart/tutorial/ingestion-tutorial-index.json`, which the tutorial never creates, so the copied command fails before submission. Use `@quickstart/ingestion-tutorial-index.json`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
