FrankChen021 commented on code in PR #19637: URL: https://github.com/apache/druid/pull/19637#discussion_r3536424728
########## docs/tutorials/tutorial-batch.md: ########## @@ -118,14 +118,19 @@ Once the spec is submitted, wait a few moments for the data to load, after which ## Loading data with a spec (via command line) -For convenience, the Druid package includes a batch ingestion helper script at `bin/post-index-task`. - -This script will POST an ingestion task to the Druid Overlord and poll Druid until the data is available for querying. +To load data with a spec, you need to POST an ingestion task to the Druid Overlord and poll Druid until the data is available for querying. Run the following command from Druid package root: ```bash -bin/post-index-task --file quickstart/tutorial/wikipedia-index.json --url http://localhost:8081 +curl -X POST http://localhost:8081/druid/indexer/v1/task \ Review Comment: [P2] Raw curl command leaves stale helper output This now submits the task with plain `curl`, which the Tasks API documents as returning only the task id, but the tutorial still says users should see the old `bin/post-index-task` polling transcript below. Readers will not get that output or automatic polling, so the tutorial should replace the transcript with real status-polling/console instructions or remove it. ########## docs/tutorials/tutorial-ingestion-spec.md: ########## @@ -580,13 +580,15 @@ We've finished defining the ingestion spec, it should now look like the followin ## Submit the task and query the data -From the `apache-druid-{{DRUIDVERSION}}` package root, run the following command: +From the `apache-druid-{{DRUIDVERSION}}` package root, run the following command to create a datasource called `ingestion tutorial`: ```bash -bin/post-index-task --file quickstart/ingestion-tutorial-index.json --url http://localhost:8081 +curl -X POST http://localhost:8081/druid/indexer/v1/task \ + -H "Content-Type: application/json" \ + -d @quickstart/tutorial/ingestion-tutorial-index.json Review Comment: [P2] Submit command points at the wrong spec path Earlier in this tutorial readers create `ingestion-tutorial-index.json` directly under `quickstart/`, but this command now posts `quickstart/tutorial/ingestion-tutorial-index.json`. Following the tutorial as written makes `curl` read a file that was never created, so the ingestion task cannot be submitted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
