cecemei opened a new pull request, #19673:
URL: https://github.com/apache/druid/pull/19673

    
   ### Description
   Adds KafkaIngestionWithCompactionTest to reproduce a bug where realtime 
pending segments are not upgraded after minor compaction.                       
                                                                                
                                                
                                             
   The bug: When minor compaction replaces V1 historical segments with V2, the 
overlord should call registerUpgradedPendingSegment on active realtime tasks to 
re-announce their pending segments at V2. In this scenario, that upgrade never 
happens, the log `==== StreamAppenderator: announcing upgraded realtime 
segment` is absent, meaning the slow supervisor's rows become invisible to 
queries once V1 segments are superseded.                                        
                                                                                
           
      
   Test setup:                                                                  
                                                                                
                                                                                
                                           
     - fastSupervisor (3s task duration): commits segments quickly              
                                                                                
                                                                                
                                           
     - slowSupervisor (100s task duration): holds an append lock throughout, 
never commits during the test window                                            
                                                                                
                                                
     - After Step 2 full compaction and Step 3 ingestion, minor compaction 
triggers in Step 4                                                              
                                                                                
                                                
     - Expected: slow supervisor's 20 realtime rows remain visible at V2; test 
observes them missing
                                                                                
                                                                                
                                                                                
                                             
   When the bug is present, assumeTrue passes and the test proceeds to a 
success, we've verified the buggy behavior end-to-end. 
   
   <hr>
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not 
all of these items apply to every PR. Remove the items which are not done or 
not relevant to the PR. None of the items from the checklist below are strictly 
necessary, but it would be very helpful if you at least self-review the PR. -->
   
   This PR has:
   
   - [ ] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] a release note entry in the PR description.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to