kfaraz commented on PR #19673: URL: https://github.com/apache/druid/pull/19673#issuecomment-4932808742
@cecemei , good catch! The problem is that the current upgrade logic sends the upgrade notification to only a single supervisor by using `SupervisorManager.getActiveSupervisorIdForDatasourceWithAppendLock()` (since this logic was written before multi supervisors was a thing). So, the upgrade notification is probably going to a supervisor which didn't actually allocate the pending segment and thus ignores the notification altogether. The fix for this would be to either send the upgrade notification to all supervisors for that datasource, or to find the one supervisor which actually allocated this segment and send the notification to it. You can update this PR to include the fix along with a simple unit test. I think we may omit the embedded test here, since it is difficult to get it to not be flaky and the value addition might not be very high. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
