jihoonson commented on a change in pull request #6883: Deprecate NoneShardSpec 
and drop support for automatic segment merge
URL: https://github.com/apache/incubator-druid/pull/6883#discussion_r265280315
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/guice/ServerModule.java
 ##########
 @@ -61,14 +55,6 @@ public ScheduledExecutorFactory 
getScheduledExecutorFactory(Lifecycle lifecycle)
   @Override
   public List<? extends Module> getJacksonModules()
   {
-    return Collections.singletonList(
-        new SimpleModule()
-            .registerSubtypes(
-                new NamedType(SingleDimensionShardSpec.class, "single"),
-                new NamedType(LinearShardSpec.class, "linear"),
-                new NamedType(NumberedShardSpec.class, "numbered"),
-                new NamedType(HashBasedNumberedShardSpec.class, "hashed")
-            )
-    );
+    return Collections.emptyList();
 
 Review comment:
   Thanks. Fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to