jihoonson commented on a change in pull request #7256: fix SequenceMetadata
deserialization
URL: https://github.com/apache/incubator-druid/pull/7256#discussion_r265284301
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java
##########
@@ -508,6 +504,7 @@ public void run()
if (isEndSequenceOffsetsExclusive() &&
createSequenceNumber(record.getSequenceNumber()).compareTo(
createSequenceNumber(endOffsets.get(record.getPartitionId()))) >= 0) {
+ stillReading = false;
Review comment:
I guess this is the change to fix the bug of stuck on resume. But, it looks
to be better to fix the
[assignPartitions](https://github.com/apache/incubator-druid/blob/master/indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java#L1033-L1038)
method which is the method to check how many offsets are remaining per
partition. This method is also called before starting the read loop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
