clintropolis commented on code in PR #19768: URL: https://github.com/apache/druid/pull/19768#discussion_r3680523809
########## processing/src/main/java/org/apache/druid/math/expr/vector/simd/SimdDoubleSinProcessor.java: ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.math.expr.vector.simd; + +import jdk.incubator.vector.DoubleVector; +import jdk.incubator.vector.VectorOperators; +import org.apache.druid.math.expr.vector.ExprVectorProcessor; +import org.apache.druid.math.expr.vector.functional.DoubleUnivariateDoubleFunction; + +import java.util.Arrays; + +/** + * SIMD specialization of {@code (double[]) -> double[]} sine. See {@link SimdSupportedUnaryOp#SIN} for the + * shared VO_MATHLIB performance notes. + */ +public final class SimdDoubleSinProcessor extends SimdDoubleUnaryProcessor +{ + public SimdDoubleSinProcessor(ExprVectorProcessor<?> input, DoubleUnivariateDoubleFunction scalarFallback) + { + super(input, scalarFallback); + } + + @Override + protected void processVector(double[] input, boolean[] inputNulls, int currentSize) + { + final int laneCount = SPECIES.length(); + final int upperBound = SPECIES.loopBound(currentSize); + int i = 0; + for (; i < upperBound; i += laneCount) { + DoubleVector.fromArray(SPECIES, input, i).lanewise(VectorOperators.SIN).intoArray(outValues, i); Review Comment: hmm, fair. It does seem pretty unlikely that someone is going to be using `sin(x)` for grouping or equality filtering, so as a compromise I've split these functions out into a separate config `useVectorMathApi` (which also requires `useVectorApi`) and documented it to call out this behavior is possible. These configs are both off by default, and this at least makes them available to operators who know they are safe since I am unsure how to reliably pre-warm compilation like this reliably at this time. Added a test that shows that after-warm-up eventually stabilizes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
