FrankChen021 commented on code in PR #19768:
URL: https://github.com/apache/druid/pull/19768#discussion_r3789338707
##########
processing/src/main/java/org/apache/druid/math/expr/ExpressionProcessing.java:
##########
@@ -45,19 +45,19 @@ public class ExpressionProcessing
@VisibleForTesting
public static void initializeForTests()
{
- INSTANCE = new ExpressionProcessingConfig(null, null, null, null);
+ INSTANCE = new ExpressionProcessingConfig(null, null, null, null, null);
}
@VisibleForTesting
public static void initializeForHomogenizeNullMultiValueStrings()
{
- INSTANCE = new ExpressionProcessingConfig(null, true, null, null);
+ INSTANCE = new ExpressionProcessingConfig(null, true, null, null, null);
}
@VisibleForTesting
public static void initializeForVectorApiTests()
{
- INSTANCE = new ExpressionProcessingConfig(null, null, null, true);
+ INSTANCE = new ExpressionProcessingConfig(null, null, null, true, true);
Review Comment:
The issue remains at current HEAD: `initializeForVectorApiTests()` still
enables `useVectorMathApi` at line 60, while the inherited consistency suite
compares SIMD and scalar math with exact equality. Please disable this flag in
that helper or make the affected assertions tolerance-aware.
Reviewed 42 of 42 changed files.
<!-- mergelens:review -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
