jihoonson commented on a change in pull request #7267: Logic adjustments to
SeekableStreamIndexTaskRunner.
URL: https://github.com/apache/incubator-druid/pull/7267#discussion_r265714509
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java
##########
@@ -688,11 +694,18 @@ public void onFailure(Throwable t)
status = Status.PUBLISHING;
}
- for (SequenceMetadata<PartitionIdType, SequenceOffsetType>
sequenceMetadata : sequences) {
+ for (int i = 0; i < sequences.size(); i++) {
+ final SequenceMetadata<PartitionIdType, SequenceOffsetType>
sequenceMetadata = sequences.get(i);
if (!publishingSequences.contains(sequenceMetadata.getSequenceName()))
{
- // this is done to prevent checks in sequence specific commit
supplier from failing
- sequenceMetadata.setEndOffsets(currOffsets);
- sequenceMetadata.updateAssignments(this, currOffsets);
+ final boolean isLast = i == (sequences.size() - 1);
+ if (isLast) {
Review comment:
Does it make sense to add a sanity check that the endOffsets are properly
set for non-last sequences?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
