jihoonson commented on a change in pull request #7267: Logic adjustments to
SeekableStreamIndexTaskRunner.
URL: https://github.com/apache/incubator-druid/pull/7267#discussion_r265707265
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java
##########
@@ -1582,45 +1645,47 @@ public DateTime getStartTime(@Context final
HttpServletRequest req)
return startTime;
}
- private boolean verifyInitialRecordAndSkipExclusivePartition(
- final OrderedPartitionableRecord<PartitionIdType, SequenceOffsetType>
record
+ /**
+ * This method does two things:
+ *
+ * 1) Verifies that the sequence numbers we read are at least as high as
those read previously, and throws an
+ * exception if not.
+ * 2) Returns false if we should skip this record because it's either (a)
the first record in a partition that we are
+ * needing to be exclusive on; (b) too late to read, past the endOffsets.
+ */
+ private boolean verifyRecordInRange(
+ final PartitionIdType partition,
+ final SequenceOffsetType recordOffset
)
{
// Check only for the first record among the record batch.
Review comment:
It looks that this isn't true anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
