FrankChen021 commented on code in PR #19825:
URL: https://github.com/apache/druid/pull/19825#discussion_r3697920443
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/hrtr/HttpRemoteTaskRunner.java:
##########
@@ -1385,7 +1385,7 @@ public List<String> getBlacklistedWorkers()
).collect(Collectors.toList());
}
- public Collection<ImmutableWorkerInfo> getBlackListedWorkers()
+ public Collection<ImmutableWorkerInfo> getBlacklistedWorkerInfos()
Review Comment:
P2 Preserve the existing public getBlackListedWorkers API
This removes the public `getBlackListedWorkers()` method and replaces it
with `getBlacklistedWorkerInfos()`. Downstream extensions or tests may fail to
compile, and existing binaries may hit `NoSuchMethodError`. Keep the old method
as a deprecated delegating alias or explicitly document this incompatible API
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
