Copilot commented on code in PR #19825:
URL: https://github.com/apache/druid/pull/19825#discussion_r3685768382
##########
processing/src/main/java/org/apache/druid/query/expression/NestedDataExpressions.java:
##########
@@ -854,7 +854,7 @@ public ExpressionType getOutputType(InputBindingInspector
inspector)
}
@Nullable
- static Object unwrap(ExprEval input)
+ static Object unwrapEval(ExprEval input)
{
return unwrap(input.value());
}
Review Comment:
`unwrapEval` takes a raw `ExprEval`, even though this class uses
`ExprEval<?>` elsewhere. Using the wildcard avoids raw-type warnings and better
communicates that the generic parameter is irrelevant here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
