FrankChen021 commented on code in PR #19874: URL: https://github.com/apache/druid/pull/19874#discussion_r3714580620
########## AGENTS.md: ########## @@ -52,6 +52,8 @@ Real-time analytics database. Java, Maven, multi-module project. ## Running Tests +Use JUnit 5 (`org.junit.jupiter`) for new test cases; do not add new tests using JUnit 4 (`org.junit`). Review Comment: [P2] Clarify how this applies to legacy JUnit 4 tests This applies to every new test case, including a method added to an existing JUnit 4 class. A Jupiter method in such a class does not receive its JUnit 4 `@Before` or `@Rule` setup, and modules that do not yet include the Jupiter API/engine cannot compile or discover it. Narrow the rule to new test classes, and require an existing JUnit 4 class/module to be migrated first or explicitly permit the added method to remain JUnit 4 until that migration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
