Copilot commented on code in PR #19815:
URL: https://github.com/apache/druid/pull/19815#discussion_r3720848918
##########
web-console/webpack.config.mjs:
##########
@@ -58,7 +58,7 @@ export default env => {
const plugins = [
new webpack.DefinePlugin({
'process.env': JSON.stringify({ NODE_ENV: mode }),
- 'global': {},
+ 'global': 'globalThis',
Review Comment:
Defining `global` as `globalThis` via `DefinePlugin` can break dependencies
that assign to `global` (e.g., `global = ...` becomes `globalThis = ...`, which
is an invalid assignment in strict mode). If the intent is to preserve
assign/delete behavior, define it as a property (e.g., `globalThis.global`) and
ensure the shim matches that behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
