FrankChen021 commented on code in PR #19815:
URL: https://github.com/apache/druid/pull/19815#discussion_r3728799124
##########
web-console/webpack.config.mjs:
##########
@@ -56,9 +56,14 @@ export default env => {
console.log(`Webpack running in ${mode} mode.`);
const plugins = [
+ new webpack.BannerPlugin({
+ banner: 'globalThis.global ??= globalThis;',
Review Comment:
[P2] Keep the raw banner within supported syntax
`BannerPlugin` uses `raw: true`, so this `??=` expression is prepended
verbatim and is never lowered by TypeScript or webpack. Resolving the
checked-in Browserslist configuration against this lockfile includes KaiOS 2.5,
whose Firefox 48-era engine cannot parse nullish assignment; it will reject the
entire entry bundle before the console renders. Use an ES2016-compatible
conditional assignment or route the shim through transpilation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
