hngu opened a new issue, #19891: URL: https://github.com/apache/druid/issues/19891
Hello! In this doc (https://druid.apache.org/docs/latest/development/extensions-core/approximate-histograms/#properties) for fixed bucket histograms, it shows that the range `[lowerLimit, upperLimit] will be divided into numBuckets intervals of equal size` with closed bracket notation. This means inclusivity. However, in the code itself it actually indicates `[lowerLimit, upperLimit)`: https://github.com/apache/druid/blob/master/extensions-core/histogram/src/main/java/org/apache/druid/query/aggregation/histogram/FixedBucketsHistogram.java#L389-L396 I have pasted the code in case the lines shift: ``` try { if (value < lowerLimit) { outlierHandler.handleOutlierAdd(false); return; } else if (value >= upperLimit) { outlierHandler.handleOutlierAdd(true); return; } ``` The docs are misleading. Please update! Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
