vogievetsky commented on a change in pull request #7242: [Console] Add
compaction dialog in druid console which allows users to add/edit data source
compaction configuration
URL: https://github.com/apache/incubator-druid/pull/7242#discussion_r265852660
##########
File path: web-console/src/components/auto-form.tsx
##########
@@ -16,26 +16,29 @@
* limitations under the License.
*/
-import { resolveSrv } from 'dns';
import * as React from 'react';
-import axios from 'axios';
import { InputGroup } from "@blueprintjs/core";
-import { HTMLSelect, FormGroup, NumericInput, TagInput } from
"../components/filler";
+import { HTMLSelect, FormGroup, NumericInput, TagInput, JSONInput } from
"../components/filler";
+import "./auto-form.scss";
+import {parseStringToJSON, validJson} from "../utils";
interface Field {
name: string;
label?: string;
- type: 'number' | 'size-bytes' | 'string' | 'boolean' | 'string-array';
+ type: 'number' | 'size-bytes' | 'string' | 'boolean' | 'string-array' |
'json';
min?: number;
}
export interface AutoFormProps<T> extends React.Props<any> {
fields: Field[];
model: T | null,
- onChange: (newValue: T) => void
+ onChange: (newValue: T) => void,
+ JSONErrors?: T | null,
Review comment:
do not start property names with capital letters. Treat `json` just like a
normal word in the dictionary for property names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
