vogievetsky commented on a change in pull request #7242: [Console] Add
compaction dialog in druid console which allows users to add/edit data source
compaction configuration
URL: https://github.com/apache/incubator-druid/pull/7242#discussion_r265858457
##########
File path: web-console/src/components/filler.tsx
##########
@@ -257,3 +259,63 @@ export class TagInput extends
React.Component<TagInputProps, { stringValue: stri
/>;
}
}
+
+interface JSONInputProps extends React.Props<any>{
+ onChange: (newValue: string) => void;
+ value: JSON;
+ updateErrors: ((newValue: string) => void)
+}
+
+interface JSONInputState{
+ stringValue: string;
+}
+
+export class JSONInput extends React.Component<JSONInputProps, JSONInputState>
{
+ constructor(props: JSONInputProps) {
+ super(props);
+ this.state = {
+ stringValue: ""
+ }
+ }
+
+ componentDidMount(): void {
+ const { value } = this.props;
+ const stringValue = parseJSONToString(value);
+ this.setState({
+ stringValue: stringValue
+ })
+ }
Review comment:
you need to also implement a `getDerivedStateFromProps` because if the props
change the state (stringValue) will not currently be updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
