gianm commented on code in PR #19947:
URL: https://github.com/apache/druid/pull/19947#discussion_r3758836545


##########
processing/src/main/java/org/apache/druid/segment/BitmapOffset.java:
##########
@@ -130,7 +131,13 @@ private static String factorizeFullness(long 
bitmapCardinality, long numRows)
   private IntIterator iteratorForMark;
   private int valueForMark;
 
-  public static IntIterator getReverseBitmapOffsetIterator(ImmutableBitmap 
bitmapIndex)
+  /**
+   * Returns an iterator over the set bits of "bitmapIndex", from highest to 
lowest. The returned iterator's
+   * {@link PeekableIntIterator#advanceIfNeeded(int)} deviates from its 
contract in order to remain useful:
+   * it advances as long as the next value is larger than the given value, 
i.e., it is the reverse-order
+   * analog of the forward iterator's behavior.
+   */
+  public static PeekableIntIterator 
getReverseBitmapOffsetIterator(ImmutableBitmap bitmapIndex)

Review Comment:
   I am not worried about this, this function is an internal API.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to