github-advanced-security[bot] commented on code in PR #19982:
URL: https://github.com/apache/druid/pull/19982#discussion_r3764150334
##########
processing/src/test/java/org/apache/druid/frame/processor/FrameProcessorExecutorTest.java:
##########
@@ -147,10 +147,10 @@
final ListenableFuture<Long> blasterFuture = exec.runFully(blaster,
null);
final ListenableFuture<Long> muxerFuture = exec.runFully(muxer, null);
- Assert.assertEquals(index.numRows(), (long) blasterFuture.get());
- Assert.assertEquals(index.numRows() * 2, (long) muxerFuture.get());
+ Assertions.assertEquals(index.numRows(), (long) blasterFuture.get());
+ Assertions.assertEquals(index.numRows() * 2, (long) muxerFuture.get());
Review Comment:
## CodeQL / Result of multiplication cast to wider type
Potential overflow in [int multiplication](1) before it is converted to long
by use in an invocation context.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11810)
##########
processing/src/test/java/org/apache/druid/math/expr/VectorExprResultConsistencyTest.java:
##########
@@ -799,16 +799,16 @@
NonnullPair<Expr.ObjectBinding[], Expr.VectorInputBinding> bindings
)
{
- Assert.assertTrue(StringUtils.format("Cannot vectorize[%s]", expr),
expr.canVectorize(bindings.rhs));
+ Assertions.assertTrue(expr.canVectorize(bindings.rhs),
StringUtils.format("Cannot vectorize[%s]", expr));
final ExpressionType outputType = expr.getOutputType(bindings.rhs);
final Either<String, Object[]> vectorEval = evalVector(expr, bindings.rhs,
outputType);
final Either<String, Object[]> nonVectorEval = evalNonVector(expr,
bindings.lhs, outputType);
- Assert.assertEquals(
- StringUtils.format("Errors do not match for expr[%s], bindings[%s]",
exprString, bindings.lhs),
+ Assertions.assertEquals(
nonVectorEval.isError() ? nonVectorEval.error() : "",
- vectorEval.isError() ? vectorEval.error() : ""
+ vectorEval.isError() ? vectorEval.error() : "",
+ StringUtils.format("Errors do not match for expr[%s], bindings[%s]",
exprString, bindings.lhs)
Review Comment:
## CodeQL / Implicit conversion from array to string
Implicit conversion from Array to String.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11809)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
