pirvtech commented on code in PR #19861:
URL: https://github.com/apache/druid/pull/19861#discussion_r3769197951


##########
docs/configuration/index.md:
##########
@@ -1570,6 +1570,12 @@ In `druid.segmentCache.locationSelector.strategy`, one 
of `leastBytesUsed`, `rou
 
 Note that if `druid.segmentCache.numLoadingThreads` > 1, multiple threads can 
download different segments at the same time. In this case, with the 
`leastBytesUsed` strategy or `mostAvailableSize` strategy, Historicals may 
select a sub-optimal storage location because each decision is based on a 
snapshot of the storage location status of when a segment is requested to 
download.
 
+#### Loading segments
+
+| Property                  | Description                                      
                                                                                
                                                                                
                                                                                
           | Default |
+|---------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-------|
+| `druid.segment.timeline.fastIntervalSearch` | Segment metadata is loaded 
into memory by the Historical services for serving the segments. This setting 
enables the use of an index based on Interval trees to store this metadata in 
memory for faster identification and retrieval. Set it to true to speed up 
loading and searching of segments. | false |

Review Comment:
   There isn't any significant overheard to using the interval tree over the 
TreeMap used earlier. Since it is a new feature, I suppose the reviewer wanted 
it to marinate for some time before making it the default.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to