kfaraz commented on code in PR #19861:
URL: https://github.com/apache/druid/pull/19861#discussion_r3772312266


##########
docs/configuration/index.md:
##########
@@ -1570,6 +1570,12 @@ In `druid.segmentCache.locationSelector.strategy`, one 
of `leastBytesUsed`, `rou
 
 Note that if `druid.segmentCache.numLoadingThreads` > 1, multiple threads can 
download different segments at the same time. In this case, with the 
`leastBytesUsed` strategy or `mostAvailableSize` strategy, Historicals may 
select a sub-optimal storage location because each decision is based on a 
snapshot of the storage location status of when a segment is requested to 
download.
 
+#### Loading segments
+
+| Property                  | Description                                      
                                                                                
                                                                                
                                                                  | Default |
+|---------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-------|
+| `druid.segment.timeline.fastIntervalSearch` | Segment metadata is loaded 
into memory by the Historical services to serve segments. This setting enables 
an index based on interval trees to store that metadata in memory for faster 
identification and retrieval. Set it to true to speed up loading and searching 
of segments. | false |

Review Comment:
   Slightly reworded.
   
   ```suggestion
   | `druid.segment.timeline.fastIntervalSearch` | (Experimental) Boolean flag 
to enable faster searches in the segment timeline maintained in the Historical 
memory. The segment timeline uses an [Interval 
Tree](https://en.wikipedia.org/wiki/Interval_tree)-based structure to speed up 
loading and searching of segments. | false |
   ```



##########
docs/configuration/index.md:
##########
@@ -1570,6 +1570,12 @@ In `druid.segmentCache.locationSelector.strategy`, one 
of `leastBytesUsed`, `rou
 
 Note that if `druid.segmentCache.numLoadingThreads` > 1, multiple threads can 
download different segments at the same time. In this case, with the 
`leastBytesUsed` strategy or `mostAvailableSize` strategy, Historicals may 
select a sub-optimal storage location because each decision is based on a 
snapshot of the storage location status of when a segment is requested to 
download.
 
+#### Loading segments
+
+| Property                  | Description                                      
                                                                                
                                                                                
                                                                  | Default |
+|---------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-------|
+| `druid.segment.timeline.fastIntervalSearch` | Segment metadata is loaded 
into memory by the Historical services to serve segments. This setting enables 
an index based on interval trees to store that metadata in memory for faster 
identification and retrieval. Set it to true to speed up loading and searching 
of segments. | false |

Review Comment:
   Isn't this config applicable to Brokers as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to