kfaraz commented on code in PR #20006:
URL: https://github.com/apache/druid/pull/20006#discussion_r3782503943
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/RetrieveUsedSegmentsAction.java:
##########
@@ -112,6 +160,11 @@ public TypeReference<Collection<DataSegment>>
getReturnTypeReference()
@Override
public Collection<DataSegment> perform(Task task, TaskActionToolbox toolbox)
+ {
+ return retainRequestedDetails(retrieveSegments(task, toolbox));
Review Comment:
We could consider pushing down the details filter to the storage layer, at
least for the `SegmentDetail.none()` case since that translates to just
fetching the used segment IDs, which could be answered by the primary key
itself.
That said, the segment metadata incremental cache is now enabled by default
on Overlord, so I am not sure if it would really add much value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
