gianm commented on code in PR #20006:
URL: https://github.com/apache/druid/pull/20006#discussion_r3785873802
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/RetrieveUsedSegmentsAction.java:
##########
@@ -112,6 +160,11 @@ public TypeReference<Collection<DataSegment>>
getReturnTypeReference()
@Override
public Collection<DataSegment> perform(Task task, TaskActionToolbox toolbox)
+ {
+ return retainRequestedDetails(retrieveSegments(task, toolbox));
Review Comment:
I figured that because the cache is enabled by default, it wasn't worth
doing this.
Btw, `SegmentDetail.none()` isn't *just* the segment IDs, it's also the
`shardSpec`. That part is always present because it's so common that it's
needed. (In particular you can't add segments to a timeline without it.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
