FrankChen021 commented on code in PR #20007:
URL: https://github.com/apache/druid/pull/20007#discussion_r3783669587
##########
indexing-service/src/main/java/org/apache/druid/indexing/compact/CascadingReindexingTemplate.java:
##########
@@ -464,6 +469,7 @@ private InlineSchemaDataSourceCompactionConfig.Builder
createBaseBuilder()
.withInputSegmentSizeBytes(inputSegmentSizeBytes)
.withEngine(CompactionEngine.MSQ)
.withTaskContext(taskContext)
+ .withSkipIntervals(skipIntervals)
Review Comment:
[P1] Reject compaction buckets that cross skip intervals
When a skip interval cuts through a target-granularity bucket, this iterator
can enqueue the full bucket and the submitted task can read and replace data
inside the interval that was supposed to be skipped. This is especially
dangerous with deletion rules. Reject candidates whose target compaction
interval overlaps a skip interval, and add a boundary regression test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
