kfaraz commented on code in PR #20007:
URL: https://github.com/apache/druid/pull/20007#discussion_r3794027046
##########
indexing-service/src/main/java/org/apache/druid/indexing/compact/CascadingReindexingTemplate.java:
##########
@@ -464,6 +469,7 @@ private InlineSchemaDataSourceCompactionConfig.Builder
createBaseBuilder()
.withInputSegmentSizeBytes(inputSegmentSizeBytes)
.withEngine(CompactionEngine.MSQ)
.withTaskContext(taskContext)
+ .withSkipIntervals(skipIntervals)
Review Comment:
Left a comment on the follow up PR
https://github.com/apache/druid/pull/20027#issuecomment-5312256964.
AFAICT, the code should already be doing this but I might be missing
something.
I agree with @gianm that it is definitely worth writing out a test case for
this first, if one doesn't already exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
