FrankChen021 commented on code in PR #19985:
URL: https://github.com/apache/druid/pull/19985#discussion_r3796307031
##########
server/src/main/java/org/apache/druid/segment/loading/SegmentLocalCacheManager.java:
##########
@@ -557,17 +559,31 @@ public AcquireSegmentAction acquireSegment(final
DataSegment dataSegment, final
makeOnDemandLoadSupplier(hold.getEntry(), location),
hold
);
+ } else {
+ locationFailures.add(
+ StringUtils.format(
+ "location[%s]: max[%,d] available[%,d]",
Review Comment:
[P2] Free-space failures are reported as capacity failures
When freeSpacePercent leaves insufficient physical disk space, reservation
can fail even though configured available capacity is sufficient. This branch
reports only max/available capacity and later claims the segment exceeded every
location's capacity, misleading operators. Include the physical free-space
constraint or distinguish the failure reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
